Adjust logic for supported vendor commands #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't any functional change in this fix, just a rearrangement with if else statements to address this issue: #432 Also a for loop wasn't initialized in `src/ZuluSCSI.cpp`, set the counter to 0.
|
Sorry, I wasn't being very helpful with my link in the issue. If that linked comment's intent is right, then I think the problem is actually here: Where the CD-ROM handler is being called and resolves the command before the vendor handler is called: |
|
Ahh yeah, I see the issue. Thanks! ZuluSCSI-firmware/lib/SCSI2SD/src/firmware/vendor.c Lines 174 to 177 in 3b81282 into the scsi.c above the specific device handling. |
The actual issue, as pointed out by @saybur, here: #434 (comment) was that `scsiCDRomCommand()` was handling CD-ROM specific vendor commands before `scsiVendorCommand()`, where the Toolbox vendor commands were being handled. When Apple quirks or Plextor vendor commands were enabled and Toolbox was enabled, the CD-ROM vendor commands were overriding the Toolbox commands. This fix moves `scsiToolboxCommand()` into `scsi.c` above scsiCDRomCommand to override the CD-ROM specific commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't any functional change in this fix, just a rearrangement with if else statements to address this issue: #432 Also a for loop wasn't initialized in
src/ZuluSCSI.cpp, set the counter to 0.