Various Toolbox fixes #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use constants for more magic numbers. Ensure filename buffer is zeroed. Avoid overrun of SCSI output buffer when max number of files is reached. Only report as many bytes to write as actually filled in output. Print additional debug messages.
Tested with MSCDEX and SHSUCDX, without this change they do not detect the media change, and keep reporting the file system of the first loaded CD image. If after changing image the user then attempts to navigate the new CD regardless, eventually the OS driver will get into a weird state and be unable to use the drive again.
nielsmh
force-pushed
the
fix/toolboxmiscfixes
branch
from
d8de674
to
d2b6cd9
Compare
|
@nielsmh thank you for this valuable contribution. This is awesome :) We will merge it after testing on our end has concluded. |
|
Other 0xD8 vendor commands pass testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues I found with the Toolbox implementation from #406, while implementing my own client for DOS/ASPI.
Note that these changes are only tested with my own ZuluSCSI RP2040 based hardware, on a single machine with an Adaptec host controller using ASPI8DOS.sys driver. The client software I have developed/tested with is published at https://github.com/nielsmh/escsitoolbox.
I do not own a Mac capable of running the original Toolbox software, so I don't know if these changes affect compatibility with that.