Fix Plextor 0xD8 SCSI vendor command #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A missing `else if` is causing the wrong offset being read during a Plextor 0xD8 vendor SCSI CDB. Adding the `else` fixes the issue. It may or may not address the issue #258 Also dropped the `scsi_id` parameter for the function `scsiDiskOpenHDDImage` as it is redundant, with `target_idx` parameter being the same value.
Skipped multiple if statements with single if during SD card reads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the 0xD8 command offset was being overwritten because of a missing else.
Skipped over parts of
doReadCDwhen using the 0xD8 command.Removed a redundant parameter from
scsiDiskOpenHDDImage.target_idxandscsi_idwere the same.