Plextor d8h vendor cmd #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a CD data read that is mainly for Plextor CDROM drives. It is a vendor CD Data read used mainly in duplicating CDs. It support reading more raw data then the other CD Read commands for better CD cloning. This is an attempt to address issue #258
The code now fetches data from the SD card aligned on 512 byte boundaries. This means prefetching and post-fetching from the SD card so the unaligned 2352 byte CD sector size can properly fit in the buffer. To be written over the SCSI bus. The end case where the last CD sector is read hasn't been addressed yet, so in theory the buffering code could attempt to read past the end of the SD card.
Currently the only setting is specific to CD-ROM drives. Setting `VendorExtensions = 1` under a device heading e.g. `[SCSI3]` in the `zuluscsi.ini` file will add Plextor's 0xD8 SCSI vendor command. This enables CD-ROM drives to act as certain models of Plextor's SCSI CD-ROM drives. This command reads raw CD sectors that are 2352 bytes in length. It start two sectors before the end of the TOC and since ZuluSCSI doesn't support images with raw TOC data the sector offset must start at 2 otherwise it will emit an error message.
The Plextor vendor command doReadD8 now calls doReadCD to save buffer space in SRAM. doReadCD now internally checks VendorExtensions to properly output the data over the SCSI bus.
The Pico DaynaPORT build failed to build because it ran out of SRAM. Decreasing the prefetch buffer by 512B fixed the build issue. Also updated the GitHub workflow to the new version.
morio
force-pushed
the
plextor-d8h-vendor-cmd
branch
from
23037df
to
1bf1967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Plextor CD-ROM drives' 0xD8 SCSI vendor command.
This is enabled by adding
where x is the SCSI ID for the drive
This feature was requested in issue: #258