Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added video and audio bit rate #930

Merged
merged 12 commits into from
May 7, 2020
Merged

added video and audio bit rate #930

merged 12 commits into from
May 7, 2020

Conversation

crazyxw
Copy link
Contributor

@crazyxw crazyxw commented Mar 22, 2019

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

@Overdrivr
Copy link
Collaborator

Thanks for your contribution, could you please add a test case for checking the fix works as expected ?

@Overdrivr Overdrivr added the tests-needed PRs/code submissions which need test cases added to them. label Mar 27, 2019
@crazyxw
Copy link
Contributor Author

crazyxw commented Apr 4, 2019

Tests always go wrong, I don't know how to solve them.

@Overdrivr
Copy link
Collaborator

I've had a look, it seems this is due not to your code but the website we're pulling ImageMagick from that keeps removing old binaries pretty quickly. I'll fix this in another branch with a more reliable solution, I'll let you know when it's done.

@Overdrivr
Copy link
Collaborator

@crazyxw The fix is in #936. Let's just let CI complete.

@Overdrivr
Copy link
Collaborator

@crazyxw Fix is merged. Could you please merge master onto your branch ? Tests should run properly now.

@crazyxw
Copy link
Contributor Author

crazyxw commented Apr 8, 2019

@Overdrivr Errors still exist.

@Overdrivr
Copy link
Collaborator

Thanks for the heads up, I'm working on it (#940). Keep you posted

@Overdrivr
Copy link
Collaborator

Actually, it's #941

@Overdrivr
Copy link
Collaborator

@crazyxw Should be good now, can you merge latest master into your branch ?

@crazyxw
Copy link
Contributor Author

crazyxw commented Apr 8, 2019

@Overdrivr ok,it's work.

@tburrows13 tburrows13 added LGTM Passed inspection by maintainers. and removed tests-needed PRs/code submissions which need test cases added to them. labels Feb 25, 2020
@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Feb 25, 2020
@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label Mar 10, 2020
@tburrows13 tburrows13 removed the LGTM Passed inspection by maintainers. label May 7, 2020
@coveralls
Copy link

coveralls commented May 7, 2020

Coverage Status

Coverage increased (+0.1%) to 67.363% when pulling d3f4803 on crazyxw:master into dd5aa72 on Zulko:master.

@tburrows13 tburrows13 merged commit 3b25a76 into Zulko:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants