Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified max duration error for better understanding #875

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

kapilkd13
Copy link
Contributor

@kapilkd13 kapilkd13 commented Nov 26, 2018

When embedding video larger than the maxduration set, the error thrown suggests to set max_duration param but it is rather maxduration without underscore. Also added a line to suggest in which function to make changes. It is minor, but it had me scratching my head for a minute.

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

@kapilkd13
Copy link
Contributor Author

@Zulko Can you look at this. Its very trivial PR, doesn't affect the core codebase in any way.

@Zulko
Copy link
Owner

Zulko commented Dec 12, 2018

Sure. Sorry for being slow.

@Zulko Zulko merged commit 74b2226 into Zulko:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants