-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a decorator to quit pygame #766
Conversation
I'm running:
with this PR and, after playing the video for a second, it crashes (doesn't sleep for 10 secs):
When run on the master branch, after a second of video, the last frame just sits there for 10 seconds, then disappears. |
I will check, thanks for test it. |
@tburrows13 I've updated the decorator to catch |
It appears that in the past we've never imported pygame in the test environment, so here its raising an error because its not installed. |
Ok, I've removed the tests for now, pygame will require some setting up with SDL on Travis, and I have no idea if that would ever work. |
This could be a good idea, but:
For these reasons, I'm closing this to reduce the future reviewing work. Feel free to update this code and reopen the pull if you think that could be interesting 👍 |
This fix #575