Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests, new duration arg in to_ImageClip() #724

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Added tests, new duration arg in to_ImageClip() #724

merged 1 commit into from
Feb 28, 2018

Conversation

tburrows13
Copy link
Collaborator

  • Added lots of tests for VideoClip.py and, indirectly gif_writers.py.
  • VideoClip.to_ImageClip() now accepts a duration argument.
  • A few changes to docstrings

@Zulko Zulko requested review from a user and removed request for a user February 15, 2018 13:18
@Zulko
Copy link
Owner

Zulko commented Feb 15, 2018

Hey just wanted to say thanks for all the work. I wish I had more time for this but my other projects are sucking too much brain power. Thanks a lot !

@coveralls
Copy link

coveralls commented Feb 15, 2018 •
edited
Loading

Coverage Status

Coverage increased (+4.4%) to 61.781% when pulling d3370e4 on tburrows13:videocliptest into 9474a5d on Zulko:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+4.4%) to 61.781% when pulling d3370e4 on tburrows13:videocliptest into 9474a5d on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.4%) to 61.781% when pulling d3370e4 on tburrows13:videocliptest into 9474a5d on Zulko:master.

@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Feb 28, 2018
@tburrows13 tburrows13 merged commit 6b0710e into Zulko:master Feb 28, 2018
@tburrows13 tburrows13 deleted the videocliptest branch March 30, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tburrows13 @Zulko @coveralls @kiddten