Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to export with alpha channel #679

Closed
wants to merge 4 commits into from
Closed

Conversation

jonata
Copy link

@jonata jonata commented Nov 29, 2017

This add the option to export with alpha channel, may solve #559

@Zulko
Copy link
Owner

Zulko commented Nov 29, 2017

There is a syntax error in your commit. Did you try it on your machine ?

@jonata
Copy link
Author

jonata commented Nov 29, 2017

Sorry about this.

@Zulko
Copy link
Owner

Zulko commented Nov 29, 2017

thanks for the pull request. Can you replace "withmask" by "with_mask" ?

Also, do you have by chance some (non-copyrighted) bit of masked video (just a few seconds) that we could try this on (and write a test for the test suite) ?

Ideally the story of a test would be (1) load the video in moviepy with VideoFileClip, (2) write the video to another file, with the mask, (3) load the video from the new file and check that it still has a mask.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage remained the same at 57.202% when pulling 1aa1f0b on jonata:master into f444f8c on Zulko:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.202% when pulling 1aa1f0b on jonata:master into f444f8c on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.202% when pulling 1aa1f0b on jonata:master into f444f8c on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 56.962% when pulling ebafb93 on jonata:master into f444f8c on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.202% when pulling ebafb93 on jonata:master into f444f8c on Zulko:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage remained the same at 65.005% when pulling 68c4928 on jonata:master into f670d1a on Zulko:master.

@jonata
Copy link
Author

jonata commented Nov 29, 2017

@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label Dec 3, 2017
@darknoon
Copy link

darknoon commented Jul 9, 2018

Hey @jonata , thanks for your PR, using it locally I was able to export a clip with 4444 for integrating machine learning in python into a post workflow. It would be great to get this merged into master… need someone to clean it up?

@jonata
Copy link
Author

jonata commented Jul 10, 2018

Hi @darknoon , sorry my lack of experience, what I am supposed to do now?

oyama added a commit to oyama/moviepy that referenced this pull request Nov 20, 2019
oyama added a commit to oyama/moviepy that referenced this pull request Nov 20, 2019
@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Jun 3, 2020
@tburrows13
Copy link
Collaborator

Linking #1122.

@mondeja
Copy link
Collaborator

mondeja commented Jan 13, 2021

This has been added in #1237.

@mondeja mondeja closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants