Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing #655 #656

Merged
merged 3 commits into from
Oct 12, 2017
Merged

Addressing #655 #656

merged 3 commits into from
Oct 12, 2017

Conversation

gyglim
Copy link
Contributor

@gyglim gyglim commented Oct 6, 2017 •
edited
Loading

Small fix to allow to nest context managers when subclipping a video.
Fixes #655

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 56.859% when pulling a9eee20 on gyglim:master into cd80d62 on Zulko:master.

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 57.202% when pulling 01ebcc3 on gyglim:master into cd80d62 on Zulko:master.

@tburrows13 tburrows13 added the bug-fix For PRs and issues solving bugs. label Oct 12, 2017
@tburrows13
Copy link
Collaborator

Thanks for this, it looks good, and well done for writing a test as well!

@tburrows13 tburrows13 merged commit a744df1 into Zulko:master Oct 12, 2017
@gyglim
Copy link
Contributor Author

gyglim commented Oct 17, 2017

my pleasure :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix For PRs and issues solving bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with nesting context managers
3 participants
@gyglim @coveralls @tburrows13