-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue629 #630
Issue629 #630
Commits on Jun 30, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 586632b - Browse repository at this point
Copy the full SHA 586632bView commit details -
Help tests run on Windows - don't assume temp dir or fonts.
* Python already has a feature for finding the temp dir. Changed test helper to take advantage of it. * Still outstanding: Several hard-coded references to /tmp appear in the tests. * Liberation-Mono is not commonly installed on Windows, and even when it is, the font has a different name. Provide a fall-back for Windows fonts. (Considered the use of a 3rd party tool to help select, but seemed overkill.)
Configuration menu - View commit details
-
Copy full SHA for c79d202 - Browse repository at this point
Copy the full SHA c79d202View commit details -
Help tests run on Windows - allow some flexibility in versions.
Building/finding binaries on Windows is non-trivial. Aallow some flexibility in the path levels. (I don't want to force existing users to upgrade, but new users should be allowed the later patches.)
Configuration menu - View commit details
-
Copy full SHA for 328de3d - Browse repository at this point
Copy the full SHA 328de3dView commit details
Commits on Jul 1, 2017
-
Issue 596: Add initial support for closing clips.
Doesn't do anything yet. The work is done in the subclasses that need it. Also supports context manager, to allow close to be implicitly performed without being forgotten even if an exception occurs during processes.
Configuration menu - View commit details
-
Copy full SHA for 9939f52 - Browse repository at this point
Copy the full SHA 9939f52View commit details -
Issue 596: Update doctest examples to call close.
Demonstrate good practice in the examples.
Configuration menu - View commit details
-
Copy full SHA for e50aef7 - Browse repository at this point
Copy the full SHA e50aef7View commit details -
More exception details for easier debugging of ImageMagick issues.
Especially for Windows.
Configuration menu - View commit details
-
Copy full SHA for dc4a16a - Browse repository at this point
Copy the full SHA dc4a16aView commit details -
Issue Zulko#596: Move away from expecting/requiring __del__ to be cal…
…led. The work should be done in close(). Deleting can be left for the garbage collector.
Configuration menu - View commit details
-
Copy full SHA for bf9c3ad - Browse repository at this point
Copy the full SHA bf9c3adView commit details -
Issue Zulko#596: Move ffmpeg_writer to using close.
Again, avoid depending on __del__. Add a context manager interface. Use it lower down.
Configuration menu - View commit details
-
Copy full SHA for de5cb86 - Browse repository at this point
Copy the full SHA de5cb86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 505939f - Browse repository at this point
Copy the full SHA 505939fView commit details -
Issue Zulko#596: Move AudioFileClip to use close(), away from __del__.
Was concerned that lambda might include a reference to reader that wasn't cleaned up by close, so changed it over to an equivalent self.reader. Probably has no effect, but feels safer.
Configuration menu - View commit details
-
Copy full SHA for 09bc06a - Browse repository at this point
Copy the full SHA 09bc06aView commit details -
Issue Zulko#596: Support close() on CompositeVideoClip.
Note: It does NOT close all the subclips, because they may be used again (by the caller). It is the caller's job to clean them up. But clips created by this instance are closed by this instance.
Configuration menu - View commit details
-
Copy full SHA for 495cd3e - Browse repository at this point
Copy the full SHA 495cd3eView commit details -
Issue Zulko#596: Add tests to see if this issue has been repaired.
test_resourcereleasedemo exercises the path where close is not called and demonstrates that there is a consistent problem on Windows. Even after this fix, it remains a problem that if you don't call close, moviepg will leak locked files and subprocesses. [Because the problem remains until the process ends, this is included in a separate test file.] test_resourcerelease demonstrates that when close() is called, the problem goes away.
Configuration menu - View commit details
-
Copy full SHA for 2c5307b - Browse repository at this point
Copy the full SHA 2c5307bView commit details -
Issue Zulko#596: Update tests to use close().
* Without tests changes, many of these existing tests do not pass on Windows.
Configuration menu - View commit details
-
Copy full SHA for c1a1563 - Browse repository at this point
Copy the full SHA c1a1563View commit details -
Further to PR Zulko#597: Change to Arial
Helvetica wasn't recognised by ImageMagick. Changing to another arbitrary font that should be available on all Windows machines.
Configuration menu - View commit details
-
Copy full SHA for ff38df9 - Browse repository at this point
Copy the full SHA ff38df9View commit details -
Issue Zulko#596 and Zulko#598: Updated test to support close().
Also changed test to meet Issue Zulko#598, but that is also being done in PR#585, so will require a merge.
Configuration menu - View commit details
-
Copy full SHA for c4d8e40 - Browse repository at this point
Copy the full SHA c4d8e40View commit details -
Revert "More exception details for easier debugging of ImageMagick is…
…sues." This reverts commit dc4a16a. I bundled too much into one commit. Reverting and reapplying as two separate commits for better history.
Configuration menu - View commit details
-
Copy full SHA for e72cc02 - Browse repository at this point
Copy the full SHA e72cc02View commit details -
Issue Zulko#599: test_6 doesn't test anything.
Removed as it was crashing on Windows, achieving nothing on Linux.
Configuration menu - View commit details
-
Copy full SHA for ff6688c - Browse repository at this point
Copy the full SHA ff6688cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4dcd47 - Browse repository at this point
Copy the full SHA f4dcd47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65971a0 - Browse repository at this point
Copy the full SHA 65971a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e21be36 - Browse repository at this point
Copy the full SHA e21be36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9383de5 - Browse repository at this point
Copy the full SHA 9383de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f930e8 - Browse repository at this point
Copy the full SHA 7f930e8View commit details
Commits on Jul 3, 2017
-
Issue 596: Add initial support for closing clips.
* Add key support for close() * FFMPEG_VideoWriter and FFMPEG_AudioWriter: Support close() and context managers. * Clip: support close() and context manager. Doesn't do anything itself. The work is done in the subclasses that need it. * Clip subclasses: Overrride close. * Move away from depending on clients calling__del__(). Deleting can be left to Garbage Collector. * CompositeVideoClip: Note: Don't close anything that wasn't constructed here. The client needs to be able to control the component clips. * AudioFileClip: Was concerned that lambda might include a reference to reader that wasn't cleaned up by close, so changed it over to an equivalent self.reader. Probably has no effect, but feels safer. * Update tests to use close(). * Note: While many tests pass on Linux either way, a large proportion of the existing unit tests fail on Windows without these changes. * Include changes to many doctest examples - Demonstrate good practice in the examples. * Also, migrate tests to use TEMPDIR where they were not using it. * test_duration(): also corrected a bug in the test (described in Zulko#598). This bug is also been addressed in Zulko#585, so a merge will be required. * Add two new test files: * test_resourcereleasedemo exercises the path where close is not called and demonstrates that there is a consistent problem on Windows. Even after this fix, it remains a problem that if you don't call close, moviepg will leak locked files and subprocesses. Because the problem remains until the process ends, this is included in a separate test file.] * test_resourcerelease demonstrates that when close() is called, the problem goes away. * Update documentation to include usage tips for close() Not included: * Example code has not been updated to use close().
Configuration menu - View commit details
-
Copy full SHA for 53c60b4 - Browse repository at this point
Copy the full SHA 53c60b4View commit details
Commits on Aug 4, 2017
-
Merge branch 'WindowsSupport' of C:\Users\xboxl\OneDrive\Documents\My…
…Apps\moviepy with conflicts.
Configuration menu - View commit details
-
Copy full SHA for 2221c5e - Browse repository at this point
Copy the full SHA 2221c5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c3f525 - Browse repository at this point
Copy the full SHA 7c3f525View commit details
Commits on Aug 8, 2017
-
Neaten up output and PEP8 compliance.
Also, make runnable directly (to help debugging)
Configuration menu - View commit details
-
Copy full SHA for 0c3b1be - Browse repository at this point
Copy the full SHA 0c3b1beView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce44cd7 - Browse repository at this point
Copy the full SHA ce44cd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0415123 - Browse repository at this point
Copy the full SHA 0415123View commit details -
Migrate to use requests to avoid certificate problems.
Old versions of urlretrieve have old certificates which means one of the video downloads was failing. Also requires changes to setup.py, to come.
Configuration menu - View commit details
-
Copy full SHA for 2fc414f - Browse repository at this point
Copy the full SHA 2fc414fView commit details -
Including adding ranges, removing unnecessary entries, adding missing entries, adding environment markers, changing versions, and updating pytest parameter handling.
Configuration menu - View commit details
-
Copy full SHA for ec2d5ba - Browse repository at this point
Copy the full SHA ec2d5baView commit details -
Simplification of Travis file - letting te setup.py do the heavy lifting
Remove conditional installations repeating the rules in setup.py Remove some installation of test needs repeating the rules in setup.py Add testing of installation options.
Configuration menu - View commit details
-
Copy full SHA for fc2b64e - Browse repository at this point
Copy the full SHA fc2b64eView commit details -
Configuration menu - View commit details
-
Copy full SHA for abcf4cc - Browse repository at this point
Copy the full SHA abcf4ccView commit details
Commits on Aug 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ab19580 - Browse repository at this point
Copy the full SHA ab19580View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98a4f14 - Browse repository at this point
Copy the full SHA 98a4f14View commit details