Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting text #510

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Correcting text #510

merged 1 commit into from
Mar 25, 2017

Conversation

gpantelis
Copy link
Contributor

Change the 'au' to 'and'

Change the 'au' to 'and'
@Zulko
Copy link
Owner

Zulko commented Mar 25, 2017

thanks !

@Zulko Zulko merged commit da7bd37 into Zulko:master Mar 25, 2017
@gpantelis gpantelis deleted the patch-1 branch March 25, 2017 22:51
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 47.685% when pulling 7a7555a on gpantelis:patch-1 into a2d0011 on Zulko:master.

@gpantelis
Copy link
Contributor Author

gpantelis commented Mar 25, 2017

What is coverage? sorry for this question.

@keikoro
Copy link
Collaborator

keikoro commented Mar 26, 2017

@gpantelis I asked basically the same question in #509, so will redirect you to there.

I think it tests for actual testing, so new contents/lines that are not covered by tests (which documentation and doc fixes etc. naturally aren't) will always decrease the existing "coverage" ("are these lines of code/stuff covered by tests?").

@Zulko
Copy link
Owner

Zulko commented Mar 26, 2017

The wikipedia article. Now I don't know exactly how coveralls.io decides what is code and what is not, so I woulnd't attach too much importance to the small changes it announces (+-1%) and use it more as a general indicator.

I can see two main uses: (1) if the test suite gets refactored, ensure that it still covers as much features as before. (2) if a contributor adds code introducing many new features, ensure that the pull request is contains tests that properly cover the new code.

@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants