Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #464, repeated/skipped frames in ImageSequenceClip #494

Merged
2 commits merged into from
Apr 19, 2017

Conversation

neitzal
Copy link
Contributor

@neitzal neitzal commented Mar 14, 2017

This PR fixes the occasional repeating and skipping of frames mentioned in issue #464 due to floating point inaccuracies in images_starts.

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage decreased (-0.02%) to 47.401% when pulling b7de3cc on neitzal:issue_464 into 0b40803 on Zulko:master.

@ghost
Copy link

ghost commented Mar 14, 2017

@neitzal, would it be possible for you to add a test for this that would fail before your fix, but succeeds after your fix? You can post it here or you can add it to tests/test_issues if you want. Is that okay?

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.2%) to 47.651% when pulling 7951e07 on neitzal:issue_464 into 0b40803 on Zulko:master.

@neitzal
Copy link
Contributor Author

neitzal commented Mar 14, 2017

@Earney Sure, I added a test for one failure case that now succeeds. The test is not exhaustive though, in the sense that it does not verify that no fps-number (in a reasonable range) ever produces a frame mismatch. I guess that would be a little too expensive to run every time.

@ghost
Copy link

ghost commented Mar 14, 2017

Awesome.. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2017

@Zulko do you think this would be okay to merge into the repo? I'm not an expert on ImageSequenceClip so I'm a bit hesitant.

@mbeacom mbeacom requested a review from Zulko April 5, 2017 04:08
@mbeacom mbeacom modified the milestone: Release v0.2.3.2 Apr 5, 2017
@tburrows13 tburrows13 added bug Issues that report (apparent) bugs. bug-fix For PRs and issues solving bugs. and removed bug Issues that report (apparent) bugs. labels Apr 13, 2017
@ghost ghost requested a review from tburrows13 April 19, 2017 12:38
@ghost
Copy link

ghost commented Apr 19, 2017

any objections to this PR?

@Zulko
Copy link
Owner

Zulko commented Apr 19, 2017

LGTM

@ghost ghost merged commit 167db9f into Zulko:master Apr 19, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants