Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test_compositing.py #451

Merged
35 commits merged into from Feb 28, 2017
Merged

add test_compositing.py #451

35 commits merged into from Feb 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2017

move distribution to Trusty..
get a recent version of ffmpeg since trusty has very old version, which moviepy complains about..

@coveralls
Copy link

coveralls commented Feb 28, 2017

Coverage Status

Coverage increased (+5.2%) to 31.902% when pulling 02fea19 on earney:tests into 4c7962a on Zulko:master.

@ghost ghost merged commit 16d33e3 into Zulko:master Feb 28, 2017
from moviepy.editor import *

def test_clips_array():
_red = ColorClip((1024,800), col=(255,0,0))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal vars?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbeacom .. sorry, I'm not following you. What do you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost
Copy link
Author

ghost commented Feb 28, 2017

@mbeacom. I always append my local variables with an underscore. Is that discouraged?
As the article says, I also do that for variables I consider private, and shouldn't be used externally, but that doesn't apply here.

@mbeacom
Copy link
Collaborator

mbeacom commented Feb 28, 2017

I was curious about the reasoning behind the naming convention. All good.

@ghost
Copy link
Author

ghost commented Feb 28, 2017

if we decide on a naming convention, I'm fine with trying to follow it. It may take some time for me to break old habits, but I can try. :)

@Zulko
Copy link
Owner

Zulko commented Feb 28, 2017

I have never seen such a systematic use of underscores before, are there projects that use this ? There are some rare cases where it helps understanding which variables are 'permanent' and which are throw-away, but I'm not sure they help here.

@keikoro
Copy link
Collaborator

keikoro commented Mar 3, 2017

I've never seen underscores used in front of variable names in Python, just as separators between several words making up one name.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants