fix issue #401

[ghost]

this fixes a python 3 error dealing with strings and bytes. See issue #401 for more details of this error.

[tburrows13]

This does the same as https://github.com/Zulko/moviepy/pull/295/files ?

[ghost]

Gloin1313.. I didn't see pull 295 before I created my version. Sorry. I like my solution better, but I'll let the maintainers to choose what version they like best. :)

[tburrows13]

I'm not experienced so I can't comment which I like better. I'm not even sure the other one works on Python 2, but obviously it works fine with Python 3.

[ghost]

Looking at this more closely, there is a difference..
Line 85, will also through an error on python 3

self.proc.stdin.write(frames_array.tostring())
(for python 3) needs to be
self.proc.stdin.write(frames_array.tobytes())

[ghost]

I tried my version on python 2 and python 3 and it seems to work. At least for the couple of test cases I used.

…

On Fri, Feb 10, 2017 at 9:06 AM, Gloin1313 ***@***.***> wrote: I'm not experienced so I can't comment which I like better. I'm not even sure the other one works on Python 2, but obviously it works fine with Python 3. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#403 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABGu8pJu2qp5NWIr8z4bAqYxdQxypRF1ks5rbHzkgaJpZM4L9Zsz> .

[tburrows13]

The tobytes()/tostring() difference causes an imageio crash from somewhere else when I run moviepy until I fix it in the code. However, this difference makes no difference either way.

[ghost]

that is funny.. I don't get the crash.. I'm running Ubuntu 16.10 My version of imageio is 2.1.2 (for python 3 and for python 2). What are your versions?

…

On Fri, Feb 10, 2017 at 9:12 AM, Gloin1313 ***@***.***> wrote: The tobytes()/tostring() difference causes an imageio crash from somewhere else when I run moviepy until I fix it in the code. However, this difference makes no difference either way. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#403 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABGu8kxvGqIRd8hifpTMAjTfII-8mu_rks5rbH51gaJpZM4L9Zsz> .

[ghost]

@Zulko @mbeacom anyway of getting this merged in?
Thanks!
Billy

[mbeacom]

@Earney Thanks for the contribution! I prefer your approach to this.
However, It appears this might be an issue in the ffmpeg_audiowriter as well based on the issue #335 and the resolution presented in #295.

I believe this is the appropriate way to go and it resolves #401. We'll want to resolve #335 before pushing a release.

[ghost]

Thanks. I will look into the fixing the other issue you mentioned On Feb 14, 2017 5:53 PM, "Mark Beacom" <notifications@github.com> wrote: *@mbeacom* approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#403 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABGu8reY8bJLxBoU6Q4Q37HTyg8d4cBQks5rcj5cgaJpZM4L9Zsz> .

[tburrows13]

It should be extremely easy to add this to ffmpeg_audiowriter as well

[ghost]

@mbeacom now, this pull also fixes issue #335. :)