Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_videofile preset choices doc #282

Merged
merged 4 commits into from
Apr 5, 2017
Merged

write_videofile preset choices doc #282

merged 4 commits into from
Apr 5, 2017

Conversation

gcandal
Copy link
Contributor

@gcandal gcandal commented Apr 5, 2016

Current choices don't seem to be correct according to https://trac.ffmpeg.org/wiki/Encode/H.264#a2.Chooseapreset

Copy link
Collaborator

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you mistakenly removed a space in this commit.

@mbeacom mbeacom added the documentation Related to documentation in official project docs or individual docstrings. label Feb 15, 2017
@gcandal
Copy link
Contributor Author

gcandal commented Feb 15, 2017

You were right ;)

@keikoro
Copy link
Collaborator

keikoro commented Feb 20, 2017

Is this a fix for #232?

@gcandal
Copy link
Contributor Author

gcandal commented Feb 20, 2017

Yes 👍

Copy link
Collaborator

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mbeacom mbeacom added the LGTM Passed inspection by maintainers. label Apr 5, 2017
@mbeacom mbeacom merged commit 332ca21 into Zulko:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings. LGTM Passed inspection by maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants