Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'multiply_volume' FX tests #1480

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Add 'multiply_volume' FX tests #1480

merged 2 commits into from
Jan 22, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 21, 2021

Contributes to #1355

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja added audio Related to AudioClip, or handling of audio in general. fx Related to advanced effects applied via clip.fx(), or effects in general. tests Related to individual tests in the test suite or running the test suite. labels Jan 21, 2021
@mondeja mondeja mentioned this pull request Jan 21, 2021
Open
@coveralls
Copy link

coveralls commented Jan 21, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 66.771% when pulling 5f709d0 on mondeja:test-multiply-volume into 8cc3eeb on Zulko:master.

@mondeja mondeja merged commit b37c35c into Zulko:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
audio Related to AudioClip, or handling of audio in general. fx Related to advanced effects applied via clip.fx(), or effects in general. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls