Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'speedx' FX by 'multiply_speed' #1478

Merged
merged 5 commits into from
Jan 22, 2021
Merged

Rename 'speedx' FX by 'multiply_speed' #1478

merged 5 commits into from
Jan 22, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 21, 2021

Following from #1424, renamed speedx FX by multiply_speed, link #1170.

@mondeja mondeja added refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. labels Jan 21, 2021
@coveralls
Copy link

coveralls commented Jan 21, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 66.771% when pulling f8aef15 on mondeja:rename-speedx into b37c35c on Zulko:master.

@mondeja mondeja changed the title Rename 'speedx' FX by 'multiply-speed' Rename 'speedx' FX by 'multiply_speed' Jan 21, 2021
@tburrows13
Copy link
Collaborator

Another good reason for changes the names of effectx effects is to stop them getting mixed up with mirror_x, which has a completely different meaning :D

@mondeja mondeja merged commit b576403 into Zulko:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees
No one assigned
Labels
breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mondeja @coveralls @tburrows13