Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented 'clips_array' and renamed 'cols_widths' argument by 'cols_heights' #1465

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Documented 'clips_array' and renamed 'cols_widths' argument by 'cols_heights' #1465

merged 3 commits into from
Jan 19, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 17, 2021 •
edited
Loading

  • Documented clips_array function.
  • Renamed weird cols_widths argument by cols_heights (of course, since this has not been discussed, I'll wait for feedback about this change).
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja added documentation Related to documentation in official project docs or individual docstrings. video Related to VideoClip and related classes, or handling of video in general. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. labels Jan 17, 2021
@coveralls
Copy link

coveralls commented Jan 17, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 66.04% when pulling 1f1ead4 on mondeja:better-clips_array into cea335a on Zulko:master.

@tburrows13
Copy link
Collaborator

Linking #1170 due to name change

@mondeja mondeja merged commit 3685041 into Zulko:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. documentation Related to documentation in official project docs or individual docstrings. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mondeja @coveralls @tburrows13