Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'tostring' by 'tobytes' in 'video.io.gif_writers::write_gif' #1429

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Replace 'tostring' by 'tobytes' in 'video.io.gif_writers::write_gif' #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a135b5e
Replace 'tostring' by 'tobytes' in 'video.io.gif_writers::write_gif'
mondeja Jan 12, 2021
e2e5148
Document change
mondeja Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Lots of method and parameter names have been changed. This will be explained bet
### Fixed <!-- for any bug fixes -->
- Fixed BitmapClip with fps != 1 not returning the correct frames or crashing [#1333]
- Fixed `rotate` sometimes failing with `ValueError: axes don't match array` [#1335]

- Changed deprecated `tostring` method by `tobytes` in `video.io.gif_writers::write_gif` #1429

## [v2.0.0.dev2](https://github.com/zulko/moviepy/tree/v2.0.0.dev2)

Expand Down
2 changes: 1 addition & 1 deletion moviepy/video/io/gif_writers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def write_gif(
if with_mask:
mask = 255 * clip.mask.get_frame(t)
frame = np.dstack([frame, mask]).astype("uint8")
proc1.stdin.write(frame.tostring())
proc1.stdin.write(frame.tobytes())

except IOError as err:

Expand Down