Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly center image when resizing #1420

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Correctly center image when resizing #1420

merged 3 commits into from
Jan 13, 2021

Conversation

jcbrockschmidt
Copy link
Contributor

@jcbrockschmidt jcbrockschmidt commented Jan 12, 2021 •
edited
Loading

This address issue #1418. It also likely fixes a number of other alignment issues given the un-swapping of width and height for blitting.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@jcbrockschmidt jcbrockschmidt changed the title Correctly center image when resizing (#1418) Correctly center image when resizing Jan 12, 2021
@mondeja mondeja linked an issue Jan 13, 2021 that may be closed by this pull request
Centering not working while zooming (in version 2) #1418
Closed
@mondeja mondeja removed a link to an issue Jan 13, 2021
Centering not working while zooming (in version 2) #1418
Closed
@mondeja mondeja linked an issue Jan 13, 2021 that may be closed by this pull request
Centering not working while zooming (in version 2) #1418
Closed
@mondeja mondeja added the bug-fix For PRs and issues solving bugs. label Jan 13, 2021
mondeja
mondeja approved these changes Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks right to me. Thank you @jcbrockschmidt 🙏

@mondeja mondeja merged commit df97353 into Zulko:master Jan 13, 2021
tburrows13 pushed a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
@jcbrockschmidt @tburrows13
Correctly center image when resizing (Zulko#1420)
9def27c 
* Correctly center image when resizing (Zulko#1418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja approved these changes

Assignees
No one assigned
Labels
bug-fix For PRs and issues solving bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centering not working while zooming (in version 2)
2 participants
@jcbrockschmidt @mondeja