Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: for rotating mask images. #1399

Merged
merged 7 commits into from
Apr 15, 2021
Merged

Bug fix: for rotating mask images. #1399

merged 7 commits into from
Apr 15, 2021

Conversation

gokuld
Copy link
Contributor

@gokuld gokuld commented Jan 4, 2021 •
edited
Loading

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@coveralls
Copy link

coveralls commented Jan 4, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 68.398% when pulling 11e2e77 on gokuld:fix_mask_rotate_bug into eefd853 on Zulko:master.

@mondeja mondeja added bug-fix For PRs and issues solving bugs. fx Related to advanced effects applied via clip.fx(), or effects in general. video Related to VideoClip and related classes, or handling of video in general. labels Jan 20, 2021
mondeja
mondeja approved these changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 😉

@mondeja mondeja mentioned this pull request Apr 15, 2021
Open
@mondeja mondeja merged commit 823640a into Zulko:master Apr 15, 2021
This was referenced Apr 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja approved these changes

Assignees
No one assigned
Labels
bug-fix For PRs and issues solving bugs. fx Related to advanced effects applied via clip.fx(), or effects in general. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gokuld @coveralls @mondeja