Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting tempfile path #1144

Merged
merged 4 commits into from
Apr 28, 2020
Merged

Allow setting tempfile path #1144

merged 4 commits into from
Apr 28, 2020

Conversation

tburrows13
Copy link
Collaborator

Closes #892. Depends upon #1137.

A simple feature to allow the user to specify which directory the temporary audiofile should be created in.

  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@tburrows13 tburrows13 mentioned this pull request Apr 14, 2020
Closed
@coveralls
Copy link

coveralls commented Apr 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 64.819% when pulling 30fcb24 on tburrows13:set-tempfile-path into 9cc52c2 on Zulko:master.

@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Apr 15, 2020
@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label Apr 18, 2020
@tburrows13
Copy link
Collaborator Author

I'm ready for this to be merged.

@tburrows13 tburrows13 merged commit 850a40e into Zulko:master Apr 28, 2020
@tburrows13 tburrows13 deleted the set-tempfile-path branch April 28, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Milestone
Release v2.0.0
Development

Successfully merging this pull request may close these issues.

RFE: Ability to chose path for temp file on write_videofile
2 participants
@tburrows13 @coveralls