Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated functions and parameters #1115

Merged
merged 17 commits into from
Apr 9, 2020
Merged

Remove deprecated functions and parameters #1115

merged 17 commits into from
Apr 9, 2020

Conversation

mgaitan
Copy link
Collaborator

@mgaitan mgaitan commented Mar 29, 2020

This PR remove deprecated functions and parameters, as required by #1089

@mgaitan mgaitan requested a review from tburrows13 March 29, 2020 03:25
@coveralls
Copy link

coveralls commented Mar 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 64.34% when pulling 3cfa738 on mgaitan:remove_deprecated into 7353216 on Zulko:master.

@mgaitan mgaitan changed the base branch from v2 to master March 29, 2020 04:02
@tburrows13
Copy link
Collaborator

tburrows13 commented Mar 29, 2020 •
edited
Loading

This looks exactly what I had in mind, thanks. Just a couple of notes:

Line 88 of VideoFileClip contains an erroneous verbose=False that does nothing and this would be a good PR in which to remove that. Maybe it did something useful at some point, but it is unnecessary now.

VideoClip.write_gif() and associated gif functions also contain excess verbose=False parameters. However, I'd like to do more of a rework of the gif writers, so you can leave this one for my upcoming PR.

@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Mar 29, 2020
@tburrows13 tburrows13 mentioned this pull request Mar 29, 2020
Open
7 tasks
@mgaitan
Copy link
Collaborator Author

mgaitan commented Apr 4, 2020

Please, re-check

@tburrows13
Copy link
Collaborator

I'm happy for you to merge this.

@mgaitan mgaitan merged commit 3fc80cb into Zulko:master Apr 9, 2020
@mgaitan mgaitan deleted the remove_deprecated branch April 9, 2020 13:52
@keikoro keikoro added the breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. label Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees
No one assigned
Labels
breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog.
Projects
None yet
Milestone
Release v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgaitan @coveralls @tburrows13 @keikoro