Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start v2.0 branch. Remove support for Python 2.7 & 3.4. #1103

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

tburrows13
Copy link
Collaborator

Changes in this PR:

  • Remove most compatibility try/except blocks that allowed Py2.7 support.
  • Remove compat.py and replace all places where it was used with hardcoded Py3.7 code.
  • Similar with tools.is_string
  • Stop Travis testing on Py2.7
  • Clean up version restrictions in setup.py

I've not removed Py3.5 support because there doesn't appear to be any convincing reason to unless we decide to explicitly use a Py3.6 feature or we start hitting compatibility problems with it. There is only one difference it makes at the moment; there seems to be issues with testing it with matplotlib, but tests are easily skipped with @pytest.mark.skipif(PYTHON_VERSION == '3.5' and TRAVIS, reason="travis py35") like in test_examples.py.

@coveralls
Copy link

coveralls commented Mar 20, 2020

Coverage Status

Coverage decreased (-0.2%) to 64.416% when pulling 64badbc on tburrows13:v2 into c901e1a on Zulko:v2.

@tburrows13
Copy link
Collaborator Author

tburrows13 commented Mar 20, 2020

Closes #1081.

@tburrows13 tburrows13 merged commit 8f1bc3d into Zulko:v2 Mar 20, 2020
@tburrows13 tburrows13 deleted the v2 branch March 20, 2020 15:02
@tburrows13 tburrows13 restored the v2 branch March 20, 2020 15:03
@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Mar 20, 2020
@tburrows13 tburrows13 mentioned this pull request Mar 29, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants