additional safe check in close_proc #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you explain what problem this solves exactly ? I remeber I had to do that but I can't remember why. |
|
It might been to soon to propose change, but I was looking for way to end process and release file for deletion and found it. So close_proc is public and easy to call from outside, and it might get called more than once and crash. The way I tried to use it might be invalid, but additional check should not be to 'heavy'. |
|
Fair enough. Thanks ! |
Zulko
added a commit
that referenced
this pull request
Dec 12, 2014
additional safe check in close_proc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.