Fix ffmpeg_parse_infos silently hangs on Windows when file contains m…

…any metadata (#926) * Add failing test * Fix #926 with fix from bertwagner
Zulko · Mar 27, 2019 · 350571a · 350571a
1 parent 2937786
commit 350571a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/moviepy/video/io/ffmpeg_reader.py b/moviepy/video/io/ffmpeg_reader.py
@@ -256,10 +256,9 @@ def ffmpeg_parse_infos(filename, print_infos=False, check_duration=True,
         popen_params["creationflags"] = 0x08000000
 
     proc = sp.Popen(cmd, **popen_params)
-
-    proc.stdout.readline()
-    proc.terminate()
-    infos = proc.stderr.read().decode('utf8')
+    (output, error) = proc.communicate()
+    infos = error.decode('utf8')
+
     del proc
 
     if print_infos:

diff --git a/tests/resource/sintel_with_15_chapters.mp4 b/tests/resource/sintel_with_15_chapters.mp4
diff --git a/tests/test_ffmpeg_reader.py b/tests/test_ffmpeg_reader.py
@@ -31,6 +31,9 @@ def test_ffmpeg_parse_infos():
     assert d['audio_found']
     assert d['audio_fps'] == 48000
 
+def test_ffmpeg_parse_infos_for_i926():
+    d = ffmpeg_parse_infos("tests/resource/sintel_with_15_chapters.mp4")
+    assert d['audio_found']
 
 if __name__ == '__main__':
    pytest.main()