Skip to content

Commit

Permalink
add version info and fix launch local kernel (jupyter-server#191)
Browse files Browse the repository at this point in the history
  • Loading branch information
Steve Silvester authored and GitHub Enterprise committed Sep 30, 2021
1 parent 2824e06 commit 85cd04b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
3 changes: 2 additions & 1 deletion data_studio_jupyter_extensions/configurables/provisioner.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ async def _launch_kernel_local_to_local(
await self._launch_kernel_now()

# Get the Host and connection ifo information from the kernel details endpoint.
kernel_info = await self.nbservice_client.get_kernel_details(self.process_id)
r = await self.nbservice_client.get_kernel_details(self.process_id)
kernel_info = json_decode(r.body)

# The local notebook service client *must* return the
# connection info when the kernel is started, since
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,8 @@ tag_template = "v{new_version}"
[[tool.tbump.file]]
src = "data_studio_jupyter_extensions/_version.py"

[[tool.tbump.file]]
src = "src/status.tsx"

[[tool.tbump.file]]
src = "version"
7 changes: 6 additions & 1 deletion src/status.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ import theme from '@tidbits/react-tidbits/theme';

import { ISessionContext, ReactWidget } from '@jupyterlab/apputils';

// This is managed by tbump config in pyproject.toml
const VERSION = '0.13.8';

// Define the error states
// https://github.pie.apple.com/pie-data-studio/notebook-service/blob/761d63604966db5918d2e491c0f89cce454b7f67/app/com/apple/datastudio/model/ResourceState.scala#L20
const ERROR_STATES = [
Expand Down Expand Up @@ -85,7 +88,9 @@ export const kernelStatusPlugin: JupyterFrontEndPlugin<void> = {
loggerRegistry: ILoggerRegistry,
notebookTracker: INotebookTracker
) => {
console.log('JupyterLab extension "Kernel Status" is activated!');
console.log(
`JupyterLab extension "Kernel Status" v${VERSION} is activated!`
);

const handleAdded = (sender: INotebookTracker, panel: NotebookPanel) => {
const handleStatus = (
Expand Down

0 comments on commit 85cd04b

Please sign in to comment.