Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smtp): support for unauthorized connections #170

Merged
merged 8 commits into from
Aug 2, 2019
Merged

feat(smtp): support for unauthorized connections #170

merged 8 commits into from
Aug 2, 2019

Conversation

syncush
Copy link
Collaborator

@syncush syncush commented Jul 20, 2019

Hi, predator devs!

Regarding issue #161

As followed by @enudler guideline I added the proper configuration for Nodemailer to support unauthorized connections/self-signed certificates and added the relevant doc for it.

One thing I may be missing, does your server automatically support the new key for a new configuration through Predator's REST-API?

P.S. it is my first time trying to contribute to an open-source project so I probably made some rookie mistakes, criticism is welcome.

unrelated: I loved your talk "Can you API handle this?" on the GO Open Source 2019 convention.

@NivLipetz
Copy link
Member

NivLipetz commented Jul 20, 2019

hi @syncush ! we really appreciate your contribution

first thing first, welcome to the open source world!

can you please rebase to master (we see your forked project is 7 commits behind the master)

regarding the /config endpoint in the API, it does support this new key as long as you added the key to the configDataMap as you did correctly.

regarding the TLS configuration, in order for Nodemailer to use the TLS connection without any confusion I suggest adding secure: true
image

Additionally, IMO, default values for secure and rejectUnauthorized should be false and should be set to true if the user wants the connection to specifically use TLS

happy you liked our talk :)

@syncush
Copy link
Collaborator Author

syncush commented Jul 20, 2019

Thank you for your quick response, I have never rebased (used to merge) before, I'll read about it.

@NivLipetz NivLipetz merged commit 7005be5 into Zooz:master Aug 2, 2019
@NivLipetz
Copy link
Member

@syncush thanks again!

@syncush syncush deleted the insecure-smtp-server-configuration branch August 3, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants