Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/killkubernetesjob' into clean-co…
Browse files Browse the repository at this point in the history
…ntainers-ui
  • Loading branch information
Manor committed Dec 30, 2019
2 parents b653474 + 40eff6e commit 940b200
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/jobs/models/kubernetes/jobConnector.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ module.exports.deleteAllContainers = async (jobPlatformName) => {
let pod = await getPodByName(allPredatorRunnersPods[i]);

let containers = pod.status.containerStatuses;
containers = containers.find(o => o.name === jobPlatformName);
containers = containers.find(o => o.name === 'predator-runner');
if (containers && containers.state.terminated && containers.state.terminated.finishedAt) {
await deleteContainer(pod);
deleted++;
Expand Down Expand Up @@ -115,7 +115,7 @@ async function getJobControllerUid(jobPlatformName, platformSpecificInternalRunI
async function getLogsByPodsNames(podsNames, predatorRunnerPrefix) {
let logs = [];
podsNames.forEach((podName) => {
let url = util.format('%s/api/v1/namespaces/%s/pods/%s/log?container=%s', kubernetesUrl, kubernetesNamespace, podName, predatorRunnerPrefix);
let url = util.format('%s/api/v1/namespaces/%s/pods/%s/log?container=%s', kubernetesUrl, kubernetesNamespace, podName, 'predator-runner');
let options = {
url,
method: 'GET',
Expand Down
6 changes: 3 additions & 3 deletions tests/integration-tests/jobs/createJobKubernetes-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,12 @@ describe('Create job specific kubernetes tests', async function () {
items: [{ metadata: { name: 'podA' } }, { metadata: { name: 'podB' } }]
});

nock(kubernetesConfig.kubernetesUrl).get(`/api/v1/namespaces/${kubernetesConfig.kubernetesNamespace}/pods/podA/log?container=predator`)
nock(kubernetesConfig.kubernetesUrl).get(`/api/v1/namespaces/${kubernetesConfig.kubernetesNamespace}/pods/podA/log?container=predator-runner`)
.reply(200, {
items: [{ content: 'log' }]
});

nock(kubernetesConfig.kubernetesUrl).get(`/api/v1/namespaces/${kubernetesConfig.kubernetesNamespace}/pods/podB/log?container=predator`)
nock(kubernetesConfig.kubernetesUrl).get(`/api/v1/namespaces/${kubernetesConfig.kubernetesNamespace}/pods/podB/log?container=predator-runner`)
.reply(200, {
items: [{ content: 'log' }]
});
Expand Down Expand Up @@ -391,7 +391,7 @@ describe('Create job specific kubernetes tests', async function () {
nock(kubernetesConfig.kubernetesUrl).get(`/api/v1/namespaces/${kubernetesConfig.kubernetesNamespace}/pods/podA`)
.reply(200, {
metadata: { labels: { 'job-name': 'predator.job' } },
status: { containerStatuses: [{ name: 'predator',
status: { containerStatuses: [{ name: 'predator-runner',
state: { terminated: { finishedAt: '2020' } } }, { name: 'podB',
state: {} }] }

Expand Down

0 comments on commit 940b200

Please sign in to comment.