feat(general): support for proxy url and debug for runners - code review

Zooz · Apr 16, 2019 · 663876f · 663876f
1 parent 107e753
commit 663876f
Show file tree

Hide file tree

Showing 7 changed files with 322 additions and 281 deletions.
diff --git a/docs/devguide/docs/configuration.md b/docs/devguide/docs/configuration.md
@@ -9,7 +9,7 @@ Below are variables Predator can be configured with.
 | Environment Variable        | Configuration key      	| Description                                                                             	| Configurable from UI/API 	| Default value               	|
 |-----------------------------|-----------------------	|-----------------------------------------------------------------------------------------	|--------------------------	|-----------------------------	|
 | INTERNAL_ADDRESS            | internal_address       	| The local ip address of your machine                                                    	| ✓                        	|                             	|
-| DOCKER_RUNNER_IMAGE         | docker_runner_image    	| The predator-runner docker image that will run the test                                 	| ✓                        	| zooz/predator-runner:latest 	|
+| RUNNER_DOCKER_IMAGE         | runner_docker_image    	| The predator-runner docker image that will run the test                                 	| ✓                        	| zooz/predator-runner:latest 	|
 | RUNNER_CPU                  | runner_cpu          	| Number of CPU use by the each runner                                                    	| ✓                        	| 1                           	|
 | RUNNER_MEMORY               | runner_memory       	| Max memory to use by each runner                                                        	| ✓                        	| 2048                      	|
 | DEFAULT_EMAIL_ADDRESS       | default_email_address   | Default email to send final report to, address can be configured                        	| ✓                        	|                             	|

diff --git a/docs/devguide/docs/swagger-docs.yaml b/docs/devguide/docs/swagger-docs.yaml
@@ -1576,10 +1576,12 @@ components:
           type: string
           description: Type of platform using to run predator (METRONOME,KUBERNETES,DOCKER)
         runner_cpu:
+          minimum: 0
           type: number
           description: Number of CPU use by the each runner.
         runner_memory:
           type: number
+          minimum: 128
           description: Max memory to use by each runner.
         metrics_plugin_name:
           type: string
@@ -1592,6 +1594,7 @@ components:
           description: Default email to send final report to, address can be configured
             only by using API.
         minimum_wait_for_delayed_report_status_update_in_ms:
+          minimum: 0
           type: number
           description: The minimum of time waiting for runner to report before the test considered as finished.
             configured only by using API.
@@ -1601,9 +1604,10 @@ components:
             configured only by using API.
         delay_runner_ms:
           type: number
+          minimum: 0
           description: Delay before the runners will start the test,
             useful for enviroments like kubernetes with sidecars that should be
-            initilizaed before the runner starts
+            initialized before the runner starts
         influx_metrics:
           additionalProperties: false
           type: object