Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger device turns off making it impossible to sign certain transactions #171

Closed
314159265359879 opened this issue Sep 12, 2024 · 21 comments

Comments

@314159265359879
Copy link

314159265359879 commented Sep 12, 2024

See here leather-io/extension#5857

Ledger Nano S+ firmware 1.1.2 and stacks app 0.24.2 (I checked with two devices same model).

🔗 zboto Link

@314159265359879
Copy link
Author

314159265359879 commented Sep 12, 2024

Reproduction steps
Connect Ledger to Leather (Stacks)
Click swap in the wallet
Choose a token pair and any amount
Click review and swap
Click Swap
See error: in leather shows loading animation with "Waiting for your approval"
Ledger device turns off, or screen goes blank which makes it look turned off.

@314159265359879
Copy link
Author

Retested with Xverse, the issue is the same there, screen turns off.
used app.bitflow.finance/trade to initiate a transaction to sign on the device.

@314159265359879 314159265359879 changed the title Ledger device turns off making it impossible to sign transaction Ledger device turns off making it impossible to sign certain transactions Sep 13, 2024
@brandonmarshall-tm
Copy link

Received a user report that attempting this multiple times caused their Ledger to reset completely, with them needing to re-enter their seed phrase. It happened multiple times after multiple attempts.

@TeddyManZ
Copy link

Withdraw LP on Alex have the same issue and Alex LP tokens can't send to another wallet, so my fund have been stuck because of this bug.

@314159265359879
Copy link
Author

Withdraw LP on Alex have the same issue and Alex LP tokens can't send to another wallet, so my fund have been stuck because of this bug.

Thanks for sharing, I am checking with the Zondax team for an update on this issue and its resolution. We are aware this is a serious blocker.

This is not an issue with 0.23.3 of the Stacks app, perhaps Zondax has a step by step guide on how to revert to an older version of the app to allow transactions in case of a dire need.

@TeddyManZ
Copy link

Withdraw LP on Alex have the same issue and Alex LP tokens can't send to another wallet, so my fund have been stuck because of this bug.

Thanks for sharing, I am checking with the Zondax team for an update on this issue and its resolution. We are aware this is a serious blocker.

This is not an issue with 0.23.3 of the Stacks app, perhaps Zondax has a step by step guide on how to revert to an older version of the app to allow transactions in case of a dire need.

Is the sideload the app only work on Ledger Nano S and Nano S plus ?
I only have Nano X.

@314159265359879
Copy link
Author

Withdraw LP on Alex have the same issue and Alex LP tokens can't send to another wallet, so my fund have been stuck because of this bug.

Thanks for sharing, I am checking with the Zondax team for an update on this issue and its resolution. We are aware this is a serious blocker.
This is not an issue with 0.23.3 of the Stacks app, perhaps Zondax has a step by step guide on how to revert to an older version of the app to allow transactions in case of a dire need.

Is the sideload the app only work on Ledger Nano S and Nano S plus ? I only have Nano X.

Hi again, sideloading doesn't work on the Nano X, because that device doesn't allow sideloading by design. In addition, I tested side loading 0.23.3 and that wasn't supported via hub.zondax.ch/stacks when I tried a couple days ago (with nano S+), I have asked someone from Zondax to see what is causing the issue, I have not yet heard back. I will share here when I do have a viable workaround.

@ainhoa-a
Copy link
Member

ainhoa-a commented Oct 4, 2024

You should be able now to install through Ledger Live the previous version on your NanoX while this issue is being investigated
image

@rzucher
Copy link

rzucher commented Oct 7, 2024

Hey guys, I'm not a developer but an web3 user and ether.fi moderator :)
I'm here to share my experience in the previous 3 days, where I've tried to use Bitflow's pool (stx-ststx) and at the moment of signing the transaction, my Ledger Nano X would bug, do not show the approval part and reset completely to fabric conditions (3 times) in the same scenario. Once, when trying to figure if the problem was in Ledger/Stacks app or Leather/Xverse, I've taken the device out and he went to booting mode for 3 full days on the plug.
Anyways, I see people are aware of the bug and hope to be fixed soon. Thanks!

@ainhoa-a
Copy link
Member

ainhoa-a commented Oct 7, 2024

Hi @rzucher we have rolled back to previous version while we keep investigating this issue. You should be able to instal 23.3 again from Ledger Live. Sorry for the inconveniences.

@neithanmo
Copy link
Collaborator

Hi @rzucher @314159265359879
I am investigating this issue, so it happens after transaction is reviewed and upon approval(where the transaction signing comes in) it crashes?

@rzucher
Copy link

rzucher commented Oct 10, 2024 via email

@neithanmo
Copy link
Collaborator

thanks @rzucher
i have done some improvements to the implementation although it is not going to fix the issues could possibly stop it from getting into that state and return an error instead.
but it is kind of difficult to figure out what is wrong without transaction data being passed to the device.

from the description I think the transaction being created as part of the swap operation is a contract call:

  • Does the device enters the review, and user can see the transaction info on device's screen?
  • crashes happens upon user approval?

can someone answer this? and maybe provide transaction data. I am trying to reproduce the issue myself and see if there is a sort of debug mode where I can get the serialized unsigned transaction being sent to the device

@rzucher
Copy link

rzucher commented Oct 10, 2024

1- No, the transaction (entering stx-ststx pool on Bitflow) never actually goes to the device screen, it only appears as generating/generated on Xverser/leather (tried both)
2- crashes few seconds after requesting the transaction

If you want, drop me your email I can share my logs if you think is useful :)

@neithanmo
Copy link
Collaborator

neithanmo commented Oct 10, 2024

@rzucher
Can you share those logs here? so everyone can be aware of the data we are looking at. and we can share here parts of it while going through, anyways you can share that to
natanael@zondax.ch

@rzucher
Copy link

rzucher commented Oct 10, 2024

yep sure, I was double guessing if its ok to share it, anyways here u go:
Uploading Logs RMZ.json…

@314159265359879
Copy link
Author

@neithanmo

In case helpful in debugging, here's a Leather build that logs the tx before it's passed to the device leather-io/extension#5885

@neithanmo
Copy link
Collaborator

yep sure, I was double guessing if its ok to share it, anyways here u go: Uploading Logs RMZ.json…

it seems the link is pointing to this issue, no logs file

@neithanmo
Copy link
Collaborator

@neithanmo

In case helpful in debugging, here's a Leather build that logs the tx before it's passed to the device leather-io/extension#5885

it seems the dev run(to run in testnet with some funds) does not allow doing swaps which I believe is the transaction type that triggers this issue sometimes

@neithanmo
Copy link
Collaborator

We could reproduce the issue and got the testing data we needed. fix on the making via #173

@neithanmo
Copy link
Collaborator

I could signed a swap transaction:

https://explorer.hiro.so/txid/0xb3e88ea9f8319d6bab31a598c5b9c0f3de7ba3cc9d6720b09a0dfbccdbc26d82?chain=mainnet

so will close this issue via #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@neithanmo @314159265359879 @TeddyManZ @ainhoa-a @brandonmarshall-tm @rzucher and others