Feat/eip1559 #20
Merged
Feat/eip1559 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
approved these changes
Nov 20, 2024
app/src/parser_impl_eth.c
Outdated
| case 2: | ||
| snprintf(outKey, outKeyLen, "Coin asset"); | ||
| snprintf(outVal, outValLen, "flare"); |
There was a problem hiding this comment.
Should this be upper case? Capital letter?
app/src/parser_impl_eth.c
Outdated
| CHECK_ERROR(printEVMAddress(&contractAddress, outVal, outValLen, pageIdx, pageCount)); | ||
| break; | ||
| case 1: | ||
| snprintf(outKey, outKeyLen, "Coin asset"); | ||
| snprintf(outVal, outValLen, "flare"); |
chcmedeiros
force-pushed
the
feat/eip1559
branch
from
ea6e137 to
6dce2d1
Compare
|
@chcmedeiros I don't really have an answer. It was more like a doubt. Are we sure capital letter is ok? |
I think the capital letter is ok, and it looks better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.