Check value not bigger than 0x8000'0000 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bigger or equal should fail.. |
jleni
requested changes
Mar 9, 2020
Comment on lines
179
to
183
| m.write_u32::<LittleEndian>(harden | path.purpose).unwrap(); | ||
| m.write_u32::<LittleEndian>(harden | path.coin).unwrap(); | ||
| m.write_u32::<LittleEndian>(path.account).unwrap(); | ||
| m.write_u32::<LittleEndian>(path.change).unwrap(); | ||
| m.write_u32::<LittleEndian>(path.index).unwrap(); |
There was a problem hiding this comment.
This will lead to confusion.. better not to harden anything here..
We should better unify API here with other libs.. let's not "auto-harden" and then leave this without checks..
we can another function that goes from path: str to BIP44Path where we do the checks
There was a problem hiding this comment.
we can bring the code from filecoin-rs here too for API consistency
|
Should we close this PR and open an issue to allow string path. It would be a bit more dev friendly. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.