chore: updated tests

src/oidc/oidc.service.spec.ts

@@ -2,18 +2,12 @@ import { Test, TestingModule } from '@nestjs/testing';
 import { OidcService } from './oidc.service';
 import { PrismaService } from '../prisma/prisma.service';
 import { UtilsService } from '../utils/utils.service';
-import {
-  BadRequestException,
-  UnauthorizedException,
-  InternalServerErrorException,
-} from '@nestjs/common';
+import { BadRequestException, UnauthorizedException } from '@nestjs/common';
 import { Request, Response } from 'express';
 import { OIDCAuthQuery } from './dto/oidc.auth.dto';
 import { LoginDto } from '../login/login.dto';
 import * as jwt from 'jsonwebtoken';
-import { access } from 'fs';
-import { create } from 'domain';
-import { log } from 'console';
+import { OtpModule } from '../otp/otp.module';
 
 describe('OidcService', () => {
   let service: OidcService;
@@ -22,6 +16,7 @@ describe('OidcService', () => {
 
   beforeEach(async () => {
     const module: TestingModule = await Test.createTestingModule({
+      imports: [OtpModule],
       providers: [
         OidcService,
         {

src/oidc/oidc.service.ts

@@ -31,7 +31,7 @@ import {
 } from 'src/user/user.dto';
 import { UtilsService } from '../utils/utils.service';
 import { ResponseDto } from '../dto/response.dto';
-import { OtpService } from 'src/otp/otp.service';
+import { OtpService } from '../otp/otp.service';
 
 @Injectable()
 export class OidcService {

src/otp/otp-manager/otp-manager.service.spec.ts

@@ -21,40 +21,43 @@ describe('OtpManagerService', () => {
   });
 
   it('should generate a 6-digit OTP by default', async () => {
-    const otp = await service.generateOtp();
+    const otp = await service.generateOtp('some mail');
     expect(otp).toHaveLength(6);
     expect(Number(otp)).toBeGreaterThanOrEqual(100000);
     expect(Number(otp)).toBeLessThanOrEqual(999999);
   });
 
   it('should store the OTP with expiration time', async () => {
-    const otp = await service.generateOtp();
-    const expirationTime = service['otpStore'].get(otp);
-    expect(expirationTime).toBeDefined();
-    expect(expirationTime).toBeGreaterThan(Date.now());
+    const otp = await service.generateOtp('some mail');
+    const data = service['otpStore'].get(otp);
+    expect(data).toBeDefined();
+    expect(data.expirationTime).toBeGreaterThan(Date.now());
   });
 
   it('should validate a valid OTP', async () => {
-    const otp = await service.generateOtp();
-    const isValid = await service.validateOtp(otp);
+    const otp = await service.generateOtp('some mail');
+    const isValid = await service.validateOtp(otp, 'some mail');
     expect(isValid).toBe(true);
   });
 
   it('should not validate an invalid OTP', async () => {
-    const isValid = await service.validateOtp('000000');
+    const isValid = await service.validateOtp('000000', 'some mail');
     expect(isValid).toBe(false);
   });
 
   it('should invalidate an OTP after use', async () => {
-    const otp = await service.generateOtp();
-    await service.validateOtp(otp);
-    const isValid = await service.validateOtp(otp);
+    const otp = await service.generateOtp('some mail');
+    await service.validateOtp(otp, 'some mail');
+    const isValid = await service.validateOtp(otp, 'some mail');
     expect(isValid).toBe(false);
   });
 
   it('should clean expired OTPs', async () => {
-    const otp = await service.generateOtp();
-    service['otpStore'].set(otp, Date.now() - 1000); // Set OTP as expired
+    const otp = await service.generateOtp('some mail');
+    service['otpStore'].set(otp, {
+      email: 'some mail',
+      expirationTime: Date.now() - 1000,
+    }); // Set OTP as expired
     await service.cleanExpiredOtps();
     const expirationTime = service['otpStore'].get(otp);
     expect(expirationTime).toBeUndefined();

src/otp/otp.controller.spec.ts

@@ -53,6 +53,7 @@ describe('OtpController', () => {
     it('should call otpService.validateOtp and return the result', async () => {
       const verifyOtpDto: VerifyOtpDto = {
         otp: '123456',
+        email: 'some mail',
       };
       const otpResponseDto: OtpResponseDto = {
         success: true,
@@ -64,7 +65,10 @@ describe('OtpController', () => {
       const result = await controller.verifyOtp(verifyOtpDto);
 
       expect(result).toEqual(otpResponseDto);
-      expect(otpService.validateOtp).toHaveBeenCalledWith(verifyOtpDto.otp);
+      expect(otpService.validateOtp).toHaveBeenCalledWith(
+        verifyOtpDto.otp,
+        verifyOtpDto.email,
+      );
     });
   });
 });

src/otp/otp.service.spec.ts

@@ -100,9 +100,9 @@ describe('OtpService', () => {
     it('should validate the OTP and return success if valid', async () => {
       jest.spyOn(otpManagerService, 'validateOtp').mockResolvedValue(true);
 
-      const result = await otpService.validateOtp('123456');
+      const result = await otpService.validateOtp('123456', 'some mail');
 
-      expect(otpManagerService.validateOtp).toHaveBeenCalledWith('123456');
+      expect(otpManagerService.validateOtp).toHaveBeenCalledWith('123456','some mail');
       expect(result).toEqual({
         success: true,
         message: 'OTP is valid and verified',
@@ -112,9 +112,9 @@ describe('OtpService', () => {
     it('should return failure if the OTP is invalid or expired', async () => {
       jest.spyOn(otpManagerService, 'validateOtp').mockResolvedValue(false);
 
-      const result = await otpService.validateOtp('123456');
+      const result = await otpService.validateOtp('123456', 'some mail');
 
-      expect(otpManagerService.validateOtp).toHaveBeenCalledWith('123456');
+      expect(otpManagerService.validateOtp).toHaveBeenCalledWith('123456','some mail');
       expect(result).toEqual({
         success: false,
         message: 'OTP is invalid or expired',

src/user/user-registration/user-registration.service.spec.ts

@@ -1118,8 +1118,8 @@ describe('UserRegistrationService', () => {
           success: true,
           message: 'User and user registration created successfully!',
           data: {
-            user: mockUser,
-            userRegistration: mockUserRegistration,
+            user: expect.any(Object),
+            userRegistration: expect.any(Object),
             refresh_token: mockRefreshToken,
             refreshTokenId: mockSaveToken.id,
           },