Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttachExtension::Support property rename #498

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

3x380V
Copy link
Contributor

@3x380V 3x380V commented Jun 7, 2024

Fix FreeCAD/FreeCAD#12714 consequences.

FreeCAD PR #12714 (Part: Rename AttachExtension::Support property)
renamed AttachExtension::Support property to AttachmentSupport, so
lets deal with it here.
@Zolko-123
Copy link
Owner

Thanks. I wanted to cherry-pick this one but I don't know how to do it. Could you explain how I could have merged it without a PR ?

@Zolko-123 Zolko-123 merged commit 5141be2 into Zolko-123:development Jun 7, 2024
@3x380V 3x380V deleted the fix_rename branch June 8, 2024 10:39
@Zolko-123
Copy link
Owner

Zolko-123 commented Jul 7, 2024

@3x380V : are you ladis in the forum ?

@3x380V
Copy link
Contributor Author

3x380V commented Jul 7, 2024

yes, as you an guess from my name used in commit author and as mentioned in my forum profile (not sure if that can be seen by unregistered users)

@Zolko-123
Copy link
Owner

If the question about maintainership of the stable 0.21 version arises, may I ask you to give the idea your thoughtful consideration please ?

@3x380V
Copy link
Contributor Author

3x380V commented Jul 8, 2024

Yes, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants