Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Mardown formatting + fixes + readability tweaks #2

Merged
merged 1 commit into from
Aug 11, 2019
Merged

README: Mardown formatting + fixes + readability tweaks #2

merged 1 commit into from
Aug 11, 2019

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jun 22, 2019

  • Incorporate correct markdown (remove <br>'s
  • formatting for improved readability
  • typo fixes

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 22, 2019

Preview: https://github.com/luzpaz/FreeCAD_Assembly4/tree/README-refinements

@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 21, 2019

Rebased and included latest change. Please use markdown instead of HTML.

@Zolko-123
Copy link
Owner

nice, thanx. But ... how do I include your fixes ? (I'm sorry, I don't know how to use GitHube properly)

@Zolko-123 Zolko-123 self-requested a review July 23, 2019 08:42
@luzpaz
README: Mardown formatting + fixes + readability tweaks
558e47b 
* Incorporate correct markdown (remove `<br>`'s
* formatting for improved readability  
* typo fixes
@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 23, 2019 •
edited
Loading

So in markdown if you want to specify a new line like you would in HTML via <br> you append 2 whitespaces at the end of the sentence (along with a newline) like so:
The rest of this PR you should merge because it adds those 2 whitespaces at the end of sentences where you haven't. Just merge this PR through the Github gui.

Edit: I rebased the PR to the most up to date master. So there shouldn't be any conflicts

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 7, 2019

@Zolko-123
you can merge it via the GUI. If you're not sure..give me access and I'll do it, then revoke my access after I'm done.

@Zolko-123 Zolko-123 merged commit f955c99 into Zolko-123:master Aug 11, 2019
@Zolko-123
Copy link
Owner

Zolko-123 commented Aug 11, 2019 via email

@luzpaz luzpaz deleted the README-refinements branch August 12, 2019 10:37
Zolko-123 added a commit that referenced this pull request Jan 5, 2020
@Zolko-123
v0.7.7
4c4eefd 
moved the tutorials to Resources, updated Example #1 & #2
@Anool Anool mentioned this pull request Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zolko-123 Zolko-123 Awaiting requested review from Zolko-123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luzpaz @Zolko-123