-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proper type hinting #32
Implement proper type hinting #32
Conversation
Reviewer's Guide by SourceryThis PR implements proper type hinting throughout the codebase, improving code readability and maintainability. The changes include adding type annotations to function parameters and variables, using proper Union types for multiple type options, and formatting code according to Python style guidelines. Updated class diagram for type hintingclassDiagram
class title_bar {
+hide(window: Any) None
+unhide(window: Any) None
}
class maximize_minimize_button {
+hide(window: Any) None
+unhide(window: Any) None
}
class maximize_button {
+disable(window: Any) None
+enable(window: Any) None
}
class minimize_button {
+disable(window: Any) None
+enable(window: Any) None
}
class all_stuffs {
+hide(window: Any) None
+unhide(window: Any) None
}
class window_flash {
+flash(window: Any, count: int = 5, interval: int = 1000) None
+stop(window: Any) None
}
class opacity {
+set(window: Any, opacity: float) None
}
class title_bar_color {
+set(window: Any, color: Union[Tuple[int, int, int], str]) None
+set_accent(window: Any) None
+reset(window: Any) None
}
class title_bar_text_color {
+set(window: Any, color: Union[Tuple[int, int, int], str]) None
+reset(window: Any) None
}
class border_color {
+set(window: Any, color: Union[Tuple[int, int, int], str]) None
+set_accent(window: Any) None
+reset(window: Any) None
}
class rainbow_title_bar {
+start(window: Any, interval: int = 5, color_stops: int = 5) None
+stop(window: Any) None
}
class rainbow_border {
+start(window: Any, interval: int = 5, color_stops: int = 5) None
+stop(window: Any) None
}
class window_frame {
+center(window: Any) None
+center_relative(window_parent: Any, window_child: Any) None
+move(window: Any, x: int, y: int) None
+resize(window: Any, width: int, height: int) None
+minimize(window: Any) None
+maximize(window: Any) None
+restore(window: Any) None
}
class window_animation {
+circle_motion(window: Any, count: int = 5, interval: int = 5, radius: int = 20) None
+vertical_shake(window: Any, count: int = 5, interval: int = 3, amplitude: int = 20) None
+horizontal_shake(window: Any, count: int = 5, interval: int = 3, amplitude: int = 20) None
}
class title_text {
+set(window: Any, title: str) None
+stylize(window: Any, style: int = 1) None
+reset(window: Any) None
}
class convert_color {
+convert_color(color: Union[Tuple[int, int, int], str]) int
}
class module_find {
+module_find(window: Any) int
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Zingzy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR addresses Issue #30
Summary by Sourcery
Enhancements: