Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2: Fix kivy deprecation warning for padding_x #66

Conversation

MatthewMarinets
Copy link

What is this fixing or adding?

Berserker brought up the kivy warning I think we've all been ignoring:

Deprecated property "<NumericProperty name=padding_x>" of object "<worlds.sc2wol.Client.SC2Context.run_gui.<locals>.MissionButton object at 0x00000292AF91B770>" was accessed, it will be removed in a future version

Getting rid of that

How was this tested?

Opened the client with these changes, verified the warning was not there.

If this makes graphical changes, please attach screenshots.

The UI looked the same to me

@Ziktofel
Copy link
Owner

Ziktofel commented Oct 8, 2023

Cherry picked into the maint branch

@Ziktofel Ziktofel closed this Oct 8, 2023
@MatthewMarinets MatthewMarinets deleted the sc2/fix_deprecation_warning branch May 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants