sc2: Fixed launcher not updating when connecting to a different slot #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-picked into maintenance branch, then merged maint branch into sc2-next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This came up a lot in the Starcraft async today. Disconnecting and reconnecting as a different slot without closing the client would leave the launcher unupdated, so it would display the mission order of the initial slot. It seems the condition to rebuild the mission panel just didn't account for this condition. Setting the
first_checkflag fixed it, as that is one flag that will cause a rebuild of the panel.How was this tested?
I reconnected as a different slot and successfully saw the new mission order