Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Const" code review #155

Closed
AlfredCP opened this issue Oct 30, 2021 · 2 comments · Fixed by #269
Closed

"Const" code review #155

AlfredCP opened this issue Oct 30, 2021 · 2 comments · Fixed by #269
Assignees
@ZigRazor
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue Priority:Medium Priority Label for medium priority issue

Comments

@AlfredCP
Copy link
Contributor

Following the "const whenever is possible" principle, I would suggest to add this restriction to our code in places where we want our structures not to change and force them to stay untouchable.

Already commented in @ZigRazor PR
@ZigRazor ZigRazor added enhancement New feature or request Priority:Medium Priority Label for medium priority issue good first issue Good for newcomers labels Oct 30, 2021
@AlfredCP AlfredCP assigned AlfredCP and unassigned AlfredCP Oct 30, 2021
@sidml
Copy link
Contributor

sidml commented Nov 8, 2021

@AlfredCP Did your previous PR resolve this or does this need more work ?

@AlfredCP
Copy link
Contributor Author

AlfredCP commented Nov 8, 2021

No, I did not do it. With this task I was refering to:

  • make functions "const" if they can/should.
  • Pass functions arguments as const if they can/should
  • Make critical objects const if they should not change throught a function even if they are local.

So in the end, this task would be to go through all code and check for this elements to make the code more robust.

@ZigRazor ZigRazor added the hacktoberfest hacktoberfest issue label Sep 30, 2022
@ZigRazor ZigRazor self-assigned this Oct 7, 2022
ZigRazor added a commit that referenced this issue Mar 23, 2023
@ZigRazor
Const Code Review
744745f 
Fix #155

Signed-off-by: GitHub <noreply@github.com>
@ZigRazor ZigRazor mentioned this issue Mar 23, 2023
Merged
@ZigRazor ZigRazor linked a pull request Mar 23, 2023 that will close this issue
Const Code Review #269
Merged
ZigRazor added a commit that referenced this issue Mar 23, 2023
@ZigRazor
Const Code Review (#269)
543b736 
Fix #155

Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZigRazor ZigRazor

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue Priority:Medium Priority Label for medium priority issue
Projects
@ZigRazor's issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Const Code Review ZigRazor/CXXGraph
3 participants
@ZigRazor @sidml @AlfredCP