Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded LND: delete + create multiple wallets #2864

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kaloudis
Copy link
Contributor

Description

Relates to issue: ZEUS-1649

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.10.0 milestone Feb 26, 2025
@kaloudis kaloudis force-pushed the delete-embedded-lnd branch from 9ca7dd8 to 017d9fe Compare February 26, 2025 01:37
@kaloudis kaloudis marked this pull request as draft February 26, 2025 01:46
@kaloudis kaloudis marked this pull request as ready for review February 26, 2025 02:35
@kaloudis kaloudis marked this pull request as draft February 26, 2025 03:33
@kaloudis kaloudis force-pushed the delete-embedded-lnd branch from d00a4ae to 3d17e2c Compare February 26, 2025 04:42
@kaloudis kaloudis force-pushed the delete-embedded-lnd branch from 87775b9 to e85ff87 Compare February 28, 2025 05:02
@kaloudis kaloudis force-pushed the delete-embedded-lnd branch from 49279c0 to bf4f2a0 Compare March 1, 2025 03:18
@kaloudis kaloudis requested a review from shubhamkmr04 March 1, 2025 03:21
@kaloudis kaloudis marked this pull request as ready for review March 1, 2025 03:21
@kaloudis
Copy link
Contributor Author

kaloudis commented Mar 1, 2025

Still need to potentially add a balance and channel check. Maybe we just need the latter?

@myxmaster
Copy link
Contributor

The explainer needs to be adjusted:
grafik

@myxmaster
Copy link
Contributor

Still need to potentially add a balance and channel check. Maybe we just need the latter?

In case there is on-chain balance only, a last reminder (info modal) about seed backup would be good I think.

And in case channels exist, an info modal should explain that channels should be closed first, otherwise force close will happen during recovery.

In both cases we should maybe even force the user to check a box to confirm that seed back up exists / he is aware of force close, to be able to proceed. I think more friction is acceptable here, because deleting the embedded node should be a rare case, and we know that still some users will complain because they don't have their seed or are annoyed by the waiting time/fees because of force closes...

@myxmaster
Copy link
Contributor

myxmaster commented Mar 1, 2025

When I have persistent mode disabled and then delete the embedded node, Zeus restarts and auto connects to my only other node config (polar LND REST in this case) and then I have a notification that LND is running in the background... This is on Android emulator Pixel_9_Pro_API_35.

@kaloudis kaloudis force-pushed the delete-embedded-lnd branch from 38d4505 to 4d12811 Compare March 1, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants