-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded LND: delete + create multiple wallets #2864
base: master
Are you sure you want to change the base?
Conversation
9ca7dd8
to
017d9fe
Compare
d00a4ae
to
3d17e2c
Compare
87775b9
to
e85ff87
Compare
49279c0
to
bf4f2a0
Compare
Still need to potentially add a balance and channel check. Maybe we just need the latter? |
In case there is on-chain balance only, a last reminder (info modal) about seed backup would be good I think. And in case channels exist, an info modal should explain that channels should be closed first, otherwise force close will happen during recovery. In both cases we should maybe even force the user to check a box to confirm that seed back up exists / he is aware of force close, to be able to proceed. I think more friction is acceptable here, because deleting the embedded node should be a rare case, and we know that still some users will complain because they don't have their seed or are annoyed by the waiting time/fees because of force closes... |
When I have persistent mode disabled and then delete the embedded node, Zeus restarts and auto connects to my only other node config (polar LND REST in this case) and then I have a notification that LND is running in the background... This is on Android emulator Pixel_9_Pro_API_35. |
38d4505
to
4d12811
Compare
Description
Relates to issue: ZEUS-1649
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: