Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts: fix PP Neue Montreal #2796

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented Feb 4, 2025

Description

Android needs fonts in android\app\src\main\assets\fonts so I copied them here. Correct casing is important for Android, so I fixed that too.

Btw: PPNeueMontreal-Medium.otf existed in assets\fonts but I don't think we need it here at all, so I deleted it.

Rebuild is required for the changes to take effect.

Before After
grafik grafik
grafik grafik
grafik grafik
grafik grafik
grafik grafik
grafik grafik

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added Design Issue relating to design Android Android issues labels Feb 4, 2025
@kaloudis kaloudis added this to the v0.10.0 milestone Feb 4, 2025
@kaloudis
Copy link
Contributor

kaloudis commented Feb 4, 2025

@myxmaster can you post before and after screenshots?

@myxmaster
Copy link
Contributor Author

I edited OP

@kaloudis kaloudis changed the title Android: Fix fonts Fonts: fix PP Neue Montreal Feb 5, 2025
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for both iOS and android.

@kaloudis kaloudis merged commit b1ceb60 into ZeusLN:master Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android issues Design Issue relating to design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants