Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add Activity Export Feature #2785

Merged
merged 11 commits into from
Feb 15, 2025

Conversation

shubhamkmr04
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 commented Jan 31, 2025

Issue : #2742

Previously, users could download CSV files from the Activity view, which included all invoice, payments and transactions combined within a specified time range.

This PR extends the functionality to the Tools section, allowing users to download invoice, payments and transactions separately with the option to filter by a specific time range.

Additionally, a new utility file, ActivityCsvUtils, has been added to keep all functions necessary for CSV generation. These are now used in both the newly added ActivityExportOptions view and the existing ActivityToCsv component
that is for CSV download functionality in the Activity view. I have also added a test file for these utils .

To-do:

  • Add the info of the downloaded file location in the header

Simulator Screenshot - iPhone 16 Pro - 2025-02-13 at 22 05 19

Simulator Screenshot - iPhone 16 Pro - 2025-02-13 at 22 07 18

Screenshot_1739530703

Simulator Screenshot - iPhone 16 Pro - 2025-02-15 at 00 06 20

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/export-csv-in-tools branch 3 times, most recently from 9732aea to 69b405f Compare February 4, 2025 09:05
@kaloudis kaloudis added this to the v0.10.0 milestone Feb 4, 2025
@shubhamkmr04 shubhamkmr04 marked this pull request as ready for review February 6, 2025 16:01
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/export-csv-in-tools branch from 25dd28a to fde74a2 Compare February 10, 2025 17:21
@shubhamkmr04
Copy link
Contributor Author

Rebased

@kaloudis
Copy link
Contributor

Need to do some more testing but this is looking pretty good so far

@kaloudis
Copy link
Contributor

@shubhamkmr04 please include a more detailed description, at least w/ screenshots

@shubhamkmr04
Copy link
Contributor Author

@shubhamkmr04 please include a more detailed description, at least w/ screenshots

sure, updated the description

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/export-csv-in-tools branch from 0a75fe1 to 8e73643 Compare February 14, 2025 10:57
locales/en.json Outdated
"views.activityExport.dateRange": "Select Date Range:",
"views.activityExport.downloadCompleteData": "Download Complete Data",
"views.activityExport.explainerAndroid": "Downloaded CSV files can be found in Files > Downloads.",
"views.activityExport.explaineriOS": "Downloaded CSV files can be found in the Files app under the ZEUS folder.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to see the Android and iOS breakdown here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you see if we can use the text character here instead? we use it in the KeyValue component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. pushed the changes

Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 8da6ee7 into ZeusLN:master Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants