-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.9.0] Accounts: hardware wallet / external signer support + batching #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kaloudis
force-pushed
the
hwi
branch
4 times, most recently
from
April 22, 2024 22:33
c5f9d5b
to
b519ac9
Compare
kaloudis
changed the title
Accounts: hardware wallet / external signer support
[v0.9.0] Accounts: hardware wallet / external signer support
Apr 23, 2024
kaloudis
changed the title
[v0.9.0] Accounts: hardware wallet / external signer support
[v0.9.0] Accounts: hardware wallet / external signer support + batching
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues: ZEUS-942, ZEUS-1121
This PR adds ability to import external accounts to the LND interfaces (embedded, REST, and LNC). With these external accounts, you can send and receive on-chain transactions, craft channel opens with airgapped funds, and observe balances in a watch-only manner.
This PR also adds the ability to send batch txs and batch open channels.
Lastly, this PR also adds the ability for generating and scanning animated QRs using both BC-ur and BBQr formats.
It has been tested against the Coldcard Q and SeedSigner hardware devices. It should work with any external signer, as Coldcard PSBT validation is the strictest we've seen so far - but no promises.
Replaces #726, which was opened almost 2 and a half years ago!
Constraints:
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: