Currency Converter #1968
Currency Converter #1968
Conversation
|
|
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
from
324e54d to
d55c28f
Compare
views/Settings/CurrencyConverter.tsx
Outdated
| <TextInput | ||
| style={styles.inputBox} | ||
| suffix={currency} | ||
| placeholder={`Enter amount in ${currency}`} |
There was a problem hiding this comment.
needs to be localized. Although here maybe we should show the currency flag as well
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
2 times, most recently
from
80a634f to
8e6a711
Compare
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
from
8e6a711 to
94d9b46
Compare
views/Settings/AddCurrencies.tsx
Outdated
| @@ -0,0 +1,156 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Do we really need this file or can we add in the functionality to SelectCurrency?
There was a problem hiding this comment.
Hmm, I'll figure out if we can without messing it up
There was a problem hiding this comment.
I have added this functionality in SelectCurrency and removed AddCurrencies
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
from
8f7aabb to
7e2e94a
Compare
assets/images/SVG/bitcoin-icon.svg
Outdated
There was a problem hiding this comment.
are we using this file anymore?
There was a problem hiding this comment.
Not right now, but I am thinking of using it in placeholder for BTC and SAT inputs.
|
I'm hitting some edge cases where I forms are unresponsive when I add them at first, sometimes. Also issues with the order not getting saved, after reordering fields. |
|
reordering is fixed now - but still having an issue with new fields not affecting the others |
|
nit: instead of writing it as SAT, let's spell out satoshis as |
|
Perhaps the country flag should always be displayed and be to the right of the currency code on the right side |
got it |
I didn't quite understand that bug. |
… suffix + change SAT to sats
| @@ -170,15 +192,15 @@ export default class CurrencyConverter extends React.Component< | |||
| // Convert the value to other currencies and BTC | |||
| Object.keys(convertedValues).forEach((key) => { | |||
| if (key !== currency) { | |||
| let conversionRate: number | null = null; | |||
| let convertedValue = ''; | |||
There was a problem hiding this comment.
why the change from a number to a string here?
There was a problem hiding this comment.
revamped this function according to type string, its better this way also because we are using numberWithDecimals and numberWithCommas now. Working perfectly now with applying the formatting to the currencies.
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
from
96a39aa to
e207327
Compare
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
from
9e5ce86 to
506299b
Compare
shubhamkmr04
force-pushed
the
shubham/CurrencyConvertor
branch
from
506299b to
d7bdebc
Compare
No description provided.