Change liveliness tokens logs from warn to debug level #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yadunund could you please review this ? |
Yadunund
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed here change the log levels of warnings about "out-of-order" unregistration of liveliness tokens from
warntodebug.The reason is that in case a remote Node is disconnected or if it shuts down abruptly (calling
rmw_shutdownand thus closing the Zenoh session before deleting its pubs/subs/services) Zenoh will locally deliver the events of liveliness tokens unregistrations in an arbitrary order. Thus it's likely that the unregistration of Node will be notified before the unregistration of its pubs/subs/services.