Fix ID generation logic (again) #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fallback in case an object is not pickleable. E.g. MagicMocks, or classes generated at runtime |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 128 128
Lines 4433 4408 -25
=========================================
- Hits 4433 4408 -25 ☔ View full report in Codecov by Sentry. |
nkemnitz
force-pushed
the
nkem/fix-dedup-logic
branch
from
a01bed3
to
7af7735
Compare
nkemnitz
force-pushed
the
nkem/fix-dedup-logic
branch
from
585b0c5
to
16ba21d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #595 - last modification broke ID persistence across runs and thus resuming most runs impossible.
dill.dumps, which seems to perfectly capture our desired behavior, results in less code, and performance is still OK-ish(?)