Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bloat through env filter #8

Closed
Zerthox opened this issue Feb 19, 2025 · 1 comment
Closed

Remove bloat through env filter #8

Zerthox opened this issue Feb 19, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Zerthox
Copy link
Owner

Zerthox commented Feb 19, 2025 •
edited
Loading

The env_filter crate introduced as dependency for logging in #5 depends on regex. Overall env_filter, regex, and its dependencies make up more than 50% of the resulting DLL for a simple addon. This is significant bloat for Nexus addons and especially bad for addons that dont even use any log filters.
@Zerthox Zerthox added the enhancement New feature or request label Feb 19, 2025
Zerthox added a commit that referenced this issue Feb 25, 2025
@Zerthox
Hide log filter behind feature (#8)
60e61f2
@Zerthox
Copy link
Owner Author

Zerthox commented Feb 25, 2025

env_filter has been hidden behind the "log_filter" feature.

@Zerthox Zerthox closed this as completed Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zerthox