Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added news Website #972

Closed
wants to merge 1 commit into from
Closed

added news Website #972

wants to merge 1 commit into from

Conversation

deepak0byte
Copy link

πŸ› οΈ Fixes Issue (Number)

πŸ‘¨β€πŸ’» Changes proposed

βœ… Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Screenshot 2022-10-12 003836

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change the JavaScript File with the correct directory structure of the repository.

  • Add proper functionality, like there is no functionality in the current code

  • The API key is publicly written. You should put it in the .env file (since the API key exposed in GitHub will not be working anymore). At least mention the service whose API key is used.

@Anmol-Baranwal Anmol-Baranwal added the changes requested Pull request is awaiting changes by the contributor label Feb 24, 2023
@Astrodevil Astrodevil closed this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you @deepak0byte for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Pull request is awaiting changes by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants